Comment On Fundamental Misunderstanding

If there's one phrase that Salvatore could attribute to his predecessor, it'd be fundamental misunderstanding. He had a fundamental misunderstanding of the business requirements. He had a fundamental misunderstanding of how to transform business requirements into code. He had a fundamental misunderstanding of how to write maintainable code. He had a fundamental misunderstanding of tools like source control. He had a fundamental misunderstanding of maintaining a modicum of documentation... even the passwords needed to access the server where the codebase (and production application) resided. [expand full text]
« PrevPage 1 | Page 2 | Page 3 | Page 4 | Page 5 | Page 6Next »

Re: Fundamental Misunderstanding

2011-03-30 09:01 • by Anon (unregistered)
"No comments have been added yet."

i feel special

Re: Fundamental Misunderstanding

2011-03-30 09:02 • by Neener (unregistered)
Boing! I hate akismet!

Re: Fundamental Misunderstanding

2011-03-30 09:03 • by JamesQMurphy
I don't know what's worse... the fact that it's called total length in SQFT (square feet), or that it's using VARCHAR(50).

Re: Fundamental Misunderstanding

2011-03-30 09:05 • by Axe (unregistered)
You seem to have a fundamental misunderstanding, first post must contain 'frist'

Re: Fundamental Misunderstanding

2011-03-30 09:07 • by frits
What Sal didn't tell you was that there was another element in the table:

Total_Height_SQFT NVARCHAR(50) NOT NULL



See, it's actually very clever...

Re: Fundamental Misunderstanding

2011-03-30 09:11 • by sotian (unregistered)
TWTF not using Metric

Re: Fundamental Misunderstanding

2011-03-30 09:12 • by the script kiddie (unregistered)
pet hate of mine, people getting units dimensionally wrong. especially when people quote energy usage in KW/h . That one, especially, makes me cry on the inside.

Re: Fundamental Misunderstanding

2011-03-30 09:19 • by steve (unregistered)
predecessor or colleague?

Re: Fundamental Misunderstanding

2011-03-30 09:23 • by Ack (unregistered)
Damn, to make long enough to even figure out what SQFT meant. Silly imperial measures....

Re: Fundamental Misunderstanding

2011-03-30 09:24 • by ca1977a
Should obviously be
Total_Length_NEWTON_SQ_SEC_PER_KILO NVARCHAR(50) NOT NULL

Re: Fundamental Misunderstanding

2011-03-30 09:24 • by Anonymous (unregistered)
Length... in square feet? 50 characters? Alphabetic characters allowed? I'm sure there's a "future proofing" joke here somewhere but damn, what sort of bizarre future is this guy proofing for?

Re: Fundamental Misunderstanding

2011-03-30 09:24 • by snoofle
article:
Total_Length_SQFT NVARCHAR(50) NOT NULL


Without context here, this is stretching to justify it, but there's a miniscule chance it might be something like a precalculated string for simplified subsequent reporting (i.e. "The computed length of feet-squared = nnn")...

Of course, it's more likely exactly as it seems at first glance...

Re: Fundamental Misunderstanding

2011-03-30 09:24 • by nonA (unregistered)
Surely TRWTF is the NOT NULL constraint.

Re: Fundamental Misunderstanding

2011-03-30 09:26 • by hoodaticus
Tell this retard to do us all a favor and never touch an RDBMS again.

Re: Fundamental Misunderstanding

2011-03-30 09:27 • by keith (unregistered)
Charitably, maybe it describes objects that are uniformly one foot wide like classroom rulers or rolls of paper towels, so the length in feet is the same numeral as the area in square feet.

Re: Fundamental Misunderstanding

2011-03-30 09:27 • by hoodaticus
342573 in reply to 342569
snoofle:
article:
Total_Length_SQFT NVARCHAR(50) NOT NULL


Without context here, this is stretching to justify it, but there's a miniscule chance it might be something like a precalculated string for simplified subsequent reporting (i.e. "The computed length of feet-squared = nnn")...

Of course, it's more likely exactly as it seems at first glance...
Which reporting technology doesn't support calculated report fields? Even if you roll your own...

Re: Fundamental Misunderstanding

2011-03-30 09:34 • by Eric (unregistered)
I almost bet if you looked at the values in that column you'd see:
'14.236m^2'
'12 acres'
'1,567 square inches'
...

Re: Fundamental Misunderstanding

2011-03-30 09:34 • by Bob (unregistered)
342575 in reply to 342572
I was thinking something similar.

Brilliantly, his code copes with all your examples even without the uniform 1ft restriction because he can specify 2PI4ftSQUARED or 6x12x1inches

Re: Fundamental Misunderstanding

2011-03-30 09:35 • by Edosoft (unregistered)
Not only is it a VARCHAR its an N varchar, so it can hold all unicode variants of.... a length or a square of feet or something

Re: Fundamental Misunderstanding

2011-03-30 09:45 • by kikito (unregistered)
That is nothing.

Near the end of my big-corporate working life, I once found a database field called "Money". A VARCHAR, of course. Depending on the record, it would hold:

* Currency names - Like "Euro", or "Dollar" (apparently "USD" was not clear enough).
* Slight variations of currency names: "Eur", "eur", "euros".
* Numbers - "112", "220".
* City names: "London", "Paris"
* Localized city names: "Londres".

That field is just an example; the whole "database" was built with the same prowess. It was an Access database, of course. The 3-month work product of a "database expert". He was called (no joke) "Scooby Doo" by his project manager. On his face.

It took me 4 days to understand the requirements and build an equivalent excel-based solution using 4 sheets.

Well, it wasn't really equivalent; my solution actually worked.

Not much later, I was "let go" from that company. Scooby Doo is still there. Apparently he's someone important's nephew. A group of Project Managers have agreed to rotate him from project to project, so the cost is shared among all.

Re: Fundamental Misunderstanding

2011-03-30 09:46 • by backForMore (unregistered)
All your units of measurement are belong to us.

Re: Fundamental Misunderstanding

2011-03-30 09:46 • by blarg (unregistered)
342581 in reply to 342557
JamesQMurphy:
I don't know what's worse... the fact that it's called total length in SQFT (square feet)


thanks for explaining the WTF for us. <--- ASKIMET, THIS IS NOT SPAM

Re: Fundamental Misunderstanding

2011-03-30 09:48 • by hoodaticus
342582 in reply to 342580
backForMore:
All your units of measurement are belong to us.
I like that.

Re: Fundamental Misunderstanding

2011-03-30 09:49 • by bertram
342583 in reply to 342555
Anon:
"No comments have been added yet."

i feel special


"Special" as in "school", yes.

Re: Fundamental Misunderstanding

2011-03-30 09:49 • by hoodaticus
342584 in reply to 342561
sotian:
TWTF not using Metric
Right, because multiplication by a constant is too difficult.

Oh wait, you do that in metric, too.

Re: Fundamental Misunderstanding

2011-03-30 09:51 • by golddog (unregistered)
Maybe in some n-dimensional space (n > 4), what we think of as a two-dimensional measure gets folded down to a single dimension?

OK, probably not.

On a related note, the chimps that originally built our database defined household number as verchar throughout the database. Then built a function used when inserting a new record which determines the new value by taking the max currently in the table, converting it to int and adding one.

Sigh.

Re: Fundamental Misunderstanding

2011-03-30 09:51 • by golddog (unregistered)
342587 in reply to 342585
golddog:
Maybe in some n-dimensional space (n > 4), what we think of as a two-dimensional measure gets folded down to a single dimension?

OK, probably not.

On a related note, the chimps that originally built our database defined household number as verchar throughout the database. Then built a function used when inserting a new record which determines the new value by taking the max currently in the table, converting it to int and adding one.

Sigh.


Or varchar. Ugh.

Re: Fundamental Misunderstanding

2011-03-30 09:52 • by hartmut (unregistered)
My favorite SQL field definition:

some_flag VARCHAR2(1) NOT NULL;

for a boolean field in an MS Access -> Oracle migration project.

As with most Microsoft products true false is zero and true is -1 (signed integer, all bits set) we ended up with '0' for false and '-' for true after the original Access data was imported.

(Do i need to mention that the person who did the schema design and import was the only certified MCSE on the project? ;)

Re: Fundamental Misunderstanding

2011-03-30 09:54 • by RichP
342589 in reply to 342561
sotian:
TWTF not using Metric


What makes you so sure that "Total_Length_SQFT" entries are not in meters (or m^2)?

Re: Fundamental Misunderstanding

2011-03-30 10:00 • by vtcodger (unregistered)
At a guess, this might be a business practice issue. My immediate thought would be that it could have started out as a sort of GIRTH+LENGTH measurement such as that used by the USPS to determine if a package is mailable and later morphed into an area -- assuming that it actually is an area and not some other hard to label function of object dimensions.

Re: Fundamental Misunderstanding

2011-03-30 10:03 • by Quicksilver
This lousy predecessor lead to R.A. Salvatore quitting his job and to become a lousy book author -> Dilbert principle fullfilled.

Re: Fundamental Misunderstanding

2011-03-30 10:04 • by QJ (unregistered)
Oh you silly people. SQFT is clearly "squirrel-feet". It's a length of 0.75644 inches, based on the original King John Imperial Red Squirrel (originally an Argentinian import, but died out in the 17th century). An important measure in the manufacture of shlocks.

Re: Fundamental Misunderstanding

2011-03-30 10:05 • by Severity One
This reminds me of a database where dates were stored as three TEXT fields. Yes, TEXT (would probably be called CLOB in Oracle), not even VARCHAR.

I shall not be rude to that contractor, because recently (and this is over 10 years later) he did some work for us, and it was actually pretty good. For me to think that something is pretty good, it has to be pretty good indeed. People do learn.

Re: Fundamental Misunderstanding

2011-03-30 10:14 • by Will Noob (unregistered)
342594 in reply to 342582
I also like that. There needs to be a facebook styled "like" button so we can all properly appreciate peoples slight witticisms...you know...because facebook hasn't quite reached every corner of the internet yet.

Re: Fundamental Misunderstanding

2011-03-30 10:18 • by hoodaticus
342595 in reply to 342562
the script kiddie:
pet hate of mine, people getting units dimensionally wrong. especially when people quote energy usage in KW/h . That one, especially, makes me cry on the inside.
But I thought power/time = energy...

Re: Fundamental Misunderstanding

2011-03-30 10:20 • by hottwaj (unregistered)
TRWTF is that he meant to write:

Total_Length_RTSQFT NVARCHAR(50) NOT NULL

right? So that it's clear that he can store real, imaginary and complex lengths in his nvarchar for the root of square feet?

Re: Fundamental Misunderstanding

2011-03-30 10:25 • by token_woman
342597 in reply to 342562
the script kiddie:
pet hate of mine, people getting units dimensionally wrong. especially when people quote energy usage in KW/h . That one, especially, makes me cry on the inside.


You mean KW/h as opposed to KWh? Does this mean I've found an ally in my annoyance at the notation "24/7"? We have customers paying over the odds for 24/7 support. I'd love to take them up on it and support them for roughly 3.4 hours a week. Wednesday afternoons, preferably - I do like a long weekend.

Re: Fundamental Misunderstanding

2011-03-30 10:25 • by metric (unregistered)
342598 in reply to 342584
hoodaticus:
sotian:
TWTF not using Metric
Right, because multiplication by a constant is too difficult.

Oh wait, you do that in metric, too.


How many square feet is a square mile?

How many square meters is a square kilometer?

I think that settles it.

Re: Fundamental Misunderstanding

2011-03-30 10:25 • by Michael (unregistered)
reminds me of a table in a DB at an investment bank I used to work for with a column "day_of_week" containing values 1 .. 31. askign a colleague, he said:"ah well, we unfortunately named in inappropriately."

Re: Fundamental Misunderstanding

2011-03-30 10:33 • by XXXXX (unregistered)
342600 in reply to 342589
Clearly because they are measured in hertz-seconds

Re: Fundamental Misunderstanding

2011-03-30 10:36 • by hoodaticus
342601 in reply to 342598
metric:
hoodaticus:
sotian:
TWTF not using Metric
Right, because multiplication by a constant is too difficult.

Oh wait, you do that in metric, too.


How many square feet is a square mile?

How many square meters is a square kilometer?

I think that settles it.
It settles nothing - you still multiply by a constant and then square it. The only difference is the constant.

If this is beyond your grasp, there is little hope for you.

Re: Fundamental Misunderstanding

2011-03-30 10:36 • by ClaudeSuck.de
342602 in reply to 342579
kikito:
That is nothing.

Near the end of my big-corporate working life, I once found a database field called "Money". A VARCHAR, of course. Depending on the record, it would hold:

* Currency names - Like "Euro", or "Dollar" (apparently "USD" was not clear enough).
* Slight variations of currency names: "Eur", "eur", "euros".
* Numbers - "112", "220".
* City names: "London", "Paris"
* Localized city names: "Londres".

That field is just an example; the whole "database" was built with the same prowess. It was an Access database, of course. The 3-month work product of a "database expert". He was called (no joke) "Scooby Doo" by his project manager. On his face.

It took me 4 days to understand the requirements and build an equivalent excel-based solution using 4 sheets.

Well, it wasn't really equivalent; my solution actually worked.

Not much later, I was "let go" from that company. Scooby Doo is still there. Apparently he's someone important's nephew. A group of Project Managers have agreed to rotate him from project to project, so the cost is shared among all.


My guess is that you screwed up their database and especially their way of working. That means your clients obviously used to use such a field like a free field where they put things as they liked.
It might be correct that referential integrity should be maintained and so on. But sometimes you would like to add a contact to your database without knowing for which company the person works. The same way probably another field in the record indicated how to interpret the value. Sales people can be like that. You probably know the "it used to work like that before", or don't you yet? "Before I could enter << London >> in order to reserve the money for a ticket whatever the cost will be."
Draughting a statistical report from these data is, of course, impossible. But that's probably not needed either.

Re: Fundamental Misunderstanding

2011-03-30 10:36 • by Anon (unregistered)
342603 in reply to 342557
JamesQMurphy:
or that it's using VARCHAR(50).


Of course you need to use VARCHAR(50), otherwise how you gonna put in values like "about 25 feet" or "10 feet, give or take a couple of inches".

PS: fuck you Akismet. Blah, blah, blah, not spam you moron.

Re: Fundamental Misunderstanding

2011-03-30 10:40 • by ClaudeSuck.de
342604 in reply to 342585
golddog:
Maybe in some n-dimensional space (n > 4), what we think of as a two-dimensional measure gets folded down to a single dimension?

OK, probably not.

On a related note, the chimps that originally built our database defined household number as verchar throughout the database. Then built a function used when inserting a new record which determines the new value by taking the max currently in the table, converting it to int and adding one.

Sigh.


There were two consultants involved: 1 to create the database with varchar as the type (requirement at creation time?). The second one to "fix" the NewValue() problem.

Re: Fundamental Misunderstanding

2011-03-30 10:41 • by AP² (unregistered)
342605 in reply to 342595
hoodaticus:
the script kiddie:
pet hate of mine, people getting units dimensionally wrong. especially when people quote energy usage in KW/h . That one, especially, makes me cry on the inside.
But I thought power/time = energy...



http://www.appropedia.org/Power_and_energy_basics#Energy_.3D_Power_x_

Re: Fundamental Misunderstanding

2011-03-30 10:47 • by boog
Alex, you left out the part where Salvatore dug a little further and discovered that yes, the column also represents length sometimes.

Re: Fundamental Misunderstanding

2011-03-30 10:47 • by hoodaticus
342607 in reply to 342605
AP²:
hoodaticus:
the script kiddie:
pet hate of mine, people getting units dimensionally wrong. especially when people quote energy usage in KW/h . That one, especially, makes me cry on the inside.
But I thought power/time = energy...



http://www.appropedia.org/Power_and_energy_basics#Energy_.3D_Power_x_
Can't it be both? And you're right, I had energy and power backwards.

Re: Fundamental Misunderstanding

2011-03-30 10:54 • by boog
342608 in reply to 342601
hoodaticus:
metric:
How many square feet is a square mile?

How many square meters is a square kilometer?

I think that settles it.
It settles nothing - you still multiply by a constant and then square it. The only difference is the constant.
Yes, but if "multiplication" only involves moving a decimal point back and forth, any moron can do it.

Re: Fundamental Misunderstanding

2011-03-30 10:55 • by Two Deep (unregistered)
342609 in reply to 342594
Will Noob:
I also like that. There needs to be a facebook styled "like" button so we can all properly appreciate peoples slight witticisms...you know...because facebook hasn't quite reached every corner of the internet yet.


I shudder to think of how CS would be integrated with FaceBook ...

Re: Fundamental Misunderstanding

2011-03-30 10:57 • by Me (unregistered)
Obviously, he is protecting against SQL injections. Everybody knows that you can't escape a numeric values, and under no circumstances can you enclose it it qoutes.
« PrevPage 1 | Page 2 | Page 3 | Page 4 | Page 5 | Page 6Next »

Add Comment