Comment On Mybad

"At my company," writes Ryan L, "we have a 'certain' developer who has been here a while but is very reluctant to learn or improve. In fact, he actively works against the rest of us when we want to implement pesky things like proper version control, design patterns, or architecture to our code behind having 3000-line code-behind files." [expand full text]
« PrevPage 1 | Page 2 | Page 3Next »

Re: Mybad

2012-05-02 20:09 • by Timeroot (unregistered)
sFrist = "Frist", then?

Re: Mybad

2012-05-02 20:11 • by K41184 (unregistered)
My first 2nd

Re: Mybad

2012-05-02 20:15 • by Callin
uhoh

myfrist

Re: Mybad

2012-05-02 20:26 • by Chrisb (unregistered)
If he was changing the key in the config file then someone else must have set the key to be that value in code.

Re: Mybad

2012-05-02 20:49 • by Anonymous Coward (unregistered)
It's an XML file: all the values are strings.

Re: Mybad

2012-05-02 21:29 • by Andrew (unregistered)
His bad indeed :p

Re: Mybad

2012-05-02 21:32 • by XXXXX (unregistered)
380271 in reply to 380269
Anonymous Coward:
It's an XML file: all the values are strings.

But that string could have been an integer, a date, or a float.
Don't you know xml schema?????

I remember back when the internet was young and all contact email addresses were dates. I could be contacted at 04-21-1628.

Re: Mybad

2012-05-02 21:40 • by Cheong (unregistered)
His bad is because the configuration use a key that's not the same as the key being used in code, of course it's "Mybad".

The comment on whether it's a string is irrelevent because it should be on seperate schema file, as most configuration files are.

If not, it's TRWTF(TM).

Re: Mybad

2012-05-02 21:40 • by Kasper (unregistered)
380273 in reply to 380271
XXXXX:
I remember back when the internet was young and all contact email addresses were dates.
Today anybody can get all the email addresses they want. Must have been great back then if anybody could get all the dates they wanted.

Re: Mybad

2012-05-02 21:47 • by MartinD (unregistered)
He corrected the config so that the key used in the config matches the key used in the code. There is no WTF here.

Re: Mybad

2012-05-02 21:59 • by ¯\(°_o)/¯ I DUNNO LOL (unregistered)
<tApp aKey="sContactEmailAddress" aValue="addrJdoe@initrode.com"/>
Dumbass. He forgot to put warts on the tags and attributes. Fixed.

Re: Mybad

2012-05-02 22:16 • by pez (unregistered)
architecture to our code behind having 3000-line code-behind files


Mybad.

Re: Mybad

2012-05-02 22:25 • by Drone (unregistered)
380277 in reply to 380273
Kasper:
XXXXX:
I remember back when the internet was young and all contact email addresses were dates.
Today anybody can get all the email addresses they want. Must have been great back then if anybody could get all the dates they wanted.

But... she told me she had to wash her hair!

Re: Mybad

2012-05-03 00:51 • by ThatGuy (unregistered)
Big deal, he added an s to the key with a dumb commit message. Sounds like the developer(s) had a gripe with this person. No WTF at all.

Re: Mybad

2012-05-03 02:29 • by Severity One
Well, me being responsible for Subversion in our company, I complained to one of our developers that he never put in a commit message, always leaving it empty. He solved that by no longer committing his code (as I found out after he left).

Re: Mybad

2012-05-03 02:29 • by Matt Westwood
So let me get this right: the real WTF is that his commit message ought to have been "myBad"? Or "sMyBad"? Come on, do tell ...

Re: Mybad

2012-05-03 02:48 • by TheRider
380281 in reply to 380279
Severity One:
Well, me being responsible for Subversion in our company, I complained to one of our developers that he never put in a commit message, always leaving it empty. He solved that by no longer committing his code (as I found out after he left).
Ouch
...or was it just as well that his code "undid" itself?

Re: Mybad

2012-05-03 03:39 • by sirhegel
380282 in reply to 380280
csMyBad to indicate that it is a comment string.

Re: Mybad

2012-05-03 03:46 • by Hatshepsut
Ryan you're an idiot.

Re: Mybad

2012-05-03 03:53 • by Lord0 (unregistered)
What a rubbish WTF. Try harder.

Re: Mybad

2012-05-03 03:57 • by Kryptus (unregistered)
<app key="sUselessComment" value="MyBad" />

<app key="sCaptcha" value="Genitus - WTF ?" />

Re: Mybad

2012-05-03 04:06 • by Alex Papadimoulis (unregistered)
380287 in reply to 380284
Lord0:
What a rubbish WTF. Try harder.

Mybad.

Re: Mybad

2012-05-03 04:21 • by Nicole (unregistered)
It might just be a more innocent mistake.

Like opening the file, trying to save it, but mistyping the CTRL + S accidentally adding an s without noticing it and actually saving it a second try and committing it (without running tests).

My suggestion: ask questions about people's intentions, instead of assuming and pointing the finger.

Re: Mybad

2012-05-03 04:38 • by Severity One
380289 in reply to 380281
TheRider:
Severity One:
Well, me being responsible for Subversion in our company, I complained to one of our developers that he never put in a commit message, always leaving it empty. He solved that by no longer committing his code (as I found out after he left).
Ouch
...or was it just as well that his code "undid" itself?
Put it this way: he's a brilliant programmer, but also bone-lazy.

So whilst he would develop really sophisticated things (involving reflection, automatic bytecode generation, and similar magic), he could never be bothered by such things like generics or proper exception handling, and he really had a fondness of arrays and static methods and members.

Re: Mybad

2012-05-03 04:45 • by Quicksilver (unregistered)
So the WTF is that people agreed on hungarian notation and one Dev fixed the notation of another?

Or that one developer fixd other's code to his preferred notation?

thats at most a W not a WTF

Re: Mybad

2012-05-03 05:29 • by Ron (unregistered)
380292 in reply to 380288
Committing code without viewing the changes and without running tests is not an innocent mistake.

Re: Mybad

2012-05-03 05:43 • by Boris (unregistered)
380293 in reply to 380274
Haven't you read the article? He corrected value , but without using design patterns! Bad boy, bad boy, err....The article suggests rest of the team would have :-)

Re: Mybad

2012-05-03 06:15 • by null (unregistered)
<app key="sComment" value="Brillant!"/>

For the earlier posters who don't "get it", this is a .Net config file value -- you don't set a schema anywhere, it's all just strings whether you like it or not.

In any event, I don't think I've ever seen someone use hungarian in the NAME of a config value. That would be as dumb as creating a data entry form where the actual on-screen labels are "sName", "sAddress", "sPhone", etc.

SCaptcha="sDamnum"

Re: Mybad

2012-05-03 07:02 • by Verdict (unregistered)
TRWTF is this getting posted at all.

Captcha: opto - This is not opto snuff

Re: Mybad

2012-05-03 07:06 • by Geoff (unregistered)
380298 in reply to 380274
You know I have had this fight before. I know there are lots of haters but I Hungarian notation is often useful in code, especially when working with languages that are not strongly typed, or offer 'features' like a variant type in an otherwise strong typed system.

When it comes to config files though I am all for striping off 's', 'i', 'o', etc and otherwise preserving the variable name. End users sometimes see config files especially when working with support. These things don't mean anything to them and it just makes the file harder to talk about, with them.

Working with code its never been difficult for my imagination to guess that SystemName="SomeName", read from a config file most likely gets stored in this variable sSystemName I am seeing all over the start up module.

Re: Mybad

2012-05-03 07:25 • by rfoxmich (unregistered)
TRWTF is XML right?

Re: Mybad

2012-05-03 07:30 • by Ralph (unregistered)
380300 in reply to 380298
Geoff:
End users sometimes see config files
Oh the horror! The humanity! Please, make it stop!

Users are only ever to see pictures. Cartoons. No words. No letters. The keyboard is very scary. Haven't you been paying attention the last 30 years?

Re: Mybad

2012-05-03 08:21 • by vt_mruhlin (unregistered)
That's really kind of a stretch to call that a WTF. He made a minor change to fix a stupid typo. Sure, the commit message could use a little work, but on a commit like that, it's at least obvious why he made the change.

It's the guy who checks in 300 lines worth of complicated changes with the message "fix a bug" that you have to worry about...

Re: Mybad

2012-05-03 08:58 • by Mike (unregistered)
380304 in reply to 380302
vt_mruhlin:
It's the guy who checks in 300 lines worth of complicated changes with the message "fix a bug" that you have to worry about...

Guilty.

Re: Mybad

2012-05-03 09:08 • by PedanticCurmudgeon
380305 in reply to 380290
Quicksilver:
So the WTF is that people agreed on hungarian notation and one Dev fixed the notation of another?

Or that one developer fixd other's code to his preferred notation?

thats at most a W not a WTF
Hungarian notation is always TRWTF.

Re: Mybad

2012-05-03 09:11 • by emaN ruoY (unregistered)
380306 in reply to 380271
XXXXX:
Anonymous Coward:
It's an XML file: all the values are strings.

But that string could have been an integer, a date, or a float.
Don't you know xml schema?????

I remember back when the internet was young and all contact email addresses were dates. I could be contacted at 04-21-1628.


I don't believe it! There was nothing in the computer world before 1970 Jan 01.

Re: Mybad

2012-05-03 09:17 • by English Man
he did a commit with no indication of what the commit was for, simply to add a Hungarian Notation prefix to a configuration file setting
So it didn't need a commit comment then did it?

Re: Mybad

2012-05-03 09:19 • by MCoder (unregistered)
380308 in reply to 380290
Quicksilver:
So the WTF is that people agreed on hungarian notation...


Yes, I'd guess so. It seems there is only one sane dev at that shop.

Re: Mybad

2012-05-03 09:37 • by ekolis
Hmm, VB.NET has the My namespace, used for configuration (My.Settings) as well as accessing standard Windows locations (My.Computer)... perhaps it needs a My.Bad class to store examples of horrible code that if the compiler finds it in your project, it flags it as an error! :D

Re: Mybad

2012-05-03 09:45 • by Mike (unregistered)
He may have just added a random character (in this case s) in front just to invalidate the key. Commenting it out.

Re: Mybad

2012-05-03 09:48 • by Shinobu (unregistered)
380311 in reply to 380302
vt_mruhlin:
He made a minor change to fix a stupid typo. ... on a commit like that, it's at least obvious why he made the change.

It's the guy who checks in 300 lines worth of complicated changes with the message "fix a bug" that you have to worry about...
I wholeheartedly agree. It's obvious that some other code needs the value of key to be sContactEmailAddress and if it's called differently, it either won't be used or it will give an error message. A silly typo, not a WTF.

Re: Mybad

2012-05-03 09:51 • by ¯\(°_o)/¯ I DUNNO LOL (unregistered)
380312 in reply to 380298
Geoff:
You know I have had this fight before. I know there are lots of haters but I Hungarian notation is often useful in code, especially when working with languages that are not strongly typed, or offer 'features' like a variant type in an otherwise strong typed system.
Indeed. I'm not against "functional" warts being used in a strongly typed language like C, indicating such things as an iIterator or nNumItems.

But then you get the WTFs like the guy in the cubicle next to me found, where a previous programmer had created a new variable simply so that he could use a different wart when he needed a variable to be 16 bits for a while, instead of 8 bits. This is in straight C code, not even C++.

Ralph:
Geoff:
End users sometimes see config files
Oh the horror! The humanity! Please, make it stop!

Users are only ever to see pictures. Cartoons. No words. No letters. The keyboard is very scary. Haven't you been paying attention the last 30 years?
We must start requiring everyone to use voice recognition and Kinect immediately. Then everyone can look just like Tom Cruise in Minority Report... or like a babbling mental ward escapee... if you can tell the difference.

Re: Mybad

2012-05-03 09:53 • by RyansBad (unregistered)
380313 in reply to 380283
Agreed. Ryan is an idiot.

Re: Mybad

2012-05-03 09:57 • by tOmcOlins
Well I hope Ryan L enjoys his mug. This is the most disappointing TwoOrThreeTimesAWeekWTF in a long time.

Re: Mybad

2012-05-03 10:12 • by hax0r (unregistered)
I'm not sure why this Ryan L. is bagging on the unnamed 'certain coder.' He insists that this developer is uninterested in learning or improving, yet the sample he provides shows said developer checking in an improvement to the code.

Re: Mybad

2012-05-03 10:16 • by KattMan
380316 in reply to 380312
¯\(°_o)/¯ I DUNNO LOL:
Then everyone can look just like Tom Cruise in Minority Report... or like a babbling mental ward escapee... if you can tell the difference.


Wait, you mean there is a difference?

Re: Mybad

2012-05-03 10:18 • by wonk (unregistered)
My god! It's full of strings!

Re: Mybad

2012-05-03 10:47 • by Nagesh (unregistered)
Why is Alex robing readers by not post article? Last two have not even been WTF :(

Re: Mybad

2012-05-03 10:53 • by Shark8 (unregistered)
380319 in reply to 380312
¯\(°_o)/¯ I DUNNO LOL:
Geoff:
You know I have had this fight before. I know there are lots of haters but I Hungarian notation is often useful in code, especially when working with languages that are not strongly typed, or offer 'features' like a variant type in an otherwise strong typed system.
Indeed. I'm not against "functional" warts being used in a strongly typed language like C, indicating such things as an iIterator or nNumItems.

Wait, what? C is not a strongly-typed language; implement a medium-sized project in Ada and you'll never think it is again.

Re: Mybad

2012-05-03 10:59 • by dkf
380320 in reply to 380319
Shark8:
Wait, what? C is not a strongly-typed language; implement a medium-sized project in Ada and you'll never think it is again.
I'll have you know that I hit the keys with much force when writing in C! If that's not strongly typed, what is?
« PrevPage 1 | Page 2 | Page 3Next »

Add Comment