Comment On Zipping Files - The Matryoshka Doll Way

Schmuli:

How is this zipping? What part of that script actually zips anything?

Phil:

Schmuli:

How is this zipping? What part of that script actually zips anything?

It first creates a small empty ZIP file by actually writing a valid header (and nothing else) to the destination ZIP. It then uses the Windows shell extensions to add the required files to the ZIP via a "Copy" operation--like copying files from one folder to another. Since Windows treats ZIP files like folders that can be copied into, this adds them to the ZIP. Actually it's a rather clever idea to avoid the use of complex (sometimes unreliable) third-party libraries, but it's implemented a bit strangely.

The_Assimilator:

Apart from the fact that the code itself is irredeemably retarded, I wonder if it'll work if Explorer isn't the handler for .zip files...

ubersoldat:

What I don't seem to find is if this thing truly does any compression.

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

if((fileName[0] != '\0'))

    fp = fopen(fileName,"w+");

else(fp = fopen("C:\\Zip.vbs","w+"));

    p.LoadString(RESID_30);

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

Scriptease:

"cmd.exe /c ..." spawns a new shell thread while "cscript /B" would block the program flow

The calling thread can use the WaitForInputIdle function to wait until the new process has finished its initialization and is waiting for user input with no input pending. This can be useful for synchronization between parent and child processes, because CreateProcess returns without waiting for the new process to finish its initialization.

Name changed to provide anonymization:

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

Actually, once the zips of zips reached a sufficiently high level of disorder the combined size of all the zips would start to grow because each iteration adds a small amount of overhead to the file. Eventually the process would create a file consuming all secondary storage on the host system.

-[Name removed to protect the guilty]

Lego:

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

Actually, once the zips of zips reached a sufficiently high level of disorder the combined size of all the zips would start to grow because each iteration adds a small amount of overhead to the file. Eventually the process would create a file consuming all secondary storage on the host system.

-Lego

dwRetVal = GetTempPath(dwBufSize, //buffer length
lpPathBuffer); //path buffer

//my name:

The real WTF is the comments:

//find temp directory;
dwRetVal = GetTempPath(dwBufSize, //buffer length
lpPathBuffer); //path buffer


//get the windows directory;
dwRetVal = GetWindowsDirectory(lpPathBuffer1,dwBufSize); //path buffer

Without these comments I'd have spend all of, err, 1 nano-second working out that GetTempPath let me find a temp directory and that GetWindowsDirectory would let me, err, get the windows directory.

Lego:

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

Actually, once the zips of zips reached a sufficiently high level of disorder the combined size of all the zips would start to grow because each iteration adds a small amount of overhead to the file. Eventually the process would create a file consuming all secondary storage on the host system.

-Lego

cod3_complete:

//my name:

The real WTF is the comments:

//find temp directory;
dwRetVal = GetTempPath(dwBufSize, //buffer length
lpPathBuffer); //path buffer


//get the windows directory;
dwRetVal = GetWindowsDirectory(lpPathBuffer1,dwBufSize); //path buffer

Without these comments I'd have spend all of, err, 1 nano-second working out that GetTempPath let me find a temp directory and that GetWindowsDirectory would let me, err, get the windows directory.

Prime example of why comments should tell *why* not *what*. I only hope the young whippersnappers are listening.

Anon:

All my comments look like this

x = x + 1 // add 1 to x

sxeraverx:

Lego:

Anon:

Anon:

With the Matryoshka doll comment I was expecting to see it zip individual files, then zip the folder of zip files recursively giving you a zip of zips of zips, and so on.
But this, is so much more insidiously retarded.

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.

Actually, once the zips of zips reached a sufficiently high level of disorder the combined size of all the zips would start to grow because each iteration adds a small amount of overhead to the file. Eventually the process would create a file consuming all secondary storage on the host system.

-Lego

Whoosh!

Or, repeatedly zip the same file until you reach the singularity of the 1 bit file.