• ray10k (unregistered)

    Which raises some serious questions about what said collegue expects String.trim() to do. As in, do they assume Strings have some hidden property that makes them unusable without a .trim() or something? I do suspect they ran into some obscure problem some time in the past, did a bunch of stuff to fix it including .trim(), and when it finally worked came to the conclusion that it was due to the .trim().

  • illogical (unregistered)

    "Frist".Trim()

  • Hannes (unregistered)

    The developer must have worked with our database before and for a long time. There's no "VARCHAR" to be seen anywhere, everything is stored in "CHAR". Which of course means you have to call Trim on just about everything (DateTime and Int excluded. Yes, at least we have those types as well), or you'll end up with a lot of trailing spaces. After a while it becomes automatic and you find yourself calling Trim where it isn't really needed.

  • balazs (unregistered) in reply to illogical

    You forgot to call ToString on it.

    So the correct frist would have been "Frist".ToString().Trim()

  • Herr Otto Flick (unregistered) in reply to Hannes

    Even if things coming from the database did need to be trimmed*, explain "False".Trim()

    • which I'm not buying. CHAR doesn't pad strings to a specific length, it simply uses exactly that number of characters in each stored tuple. IE it is about record size, not data size.
  • Ron Fox (google)

    Of course there is at least one programming language for which everything can be treated as a string.

  • Sheriff Fatman (unregistered) in reply to ray10k
    Comment held for moderation.
  • ray10k (unregistered) in reply to Ron Fox

    PHP?

  • chreng (unregistered) in reply to balazs

    I think this makes more sense: " Frist ".ToString().Trim()

  • Michael “Rosy” Luder-Rosefield (google)

    It sounds like they just got told once to always trim their strings, as good practice. Then they took that lesson out of that context, didn't really think about it, and started applying everywhere, all the time. At least they're not setting everything to lower case as well.

  • Peter (unregistered) in reply to ray10k

    It's fairly common to get padded strings when reading from a database. I'd guess that the programmer ran into that sort of problem in the past and now habitually trims everything "just in case."

  • Not very trim (unregistered) in reply to chreng

    You forgot to trim the constant before ToString()-ing it.

  • Tyisha (unregistered) in reply to Herr Otto Flick

    No, this is actually the reason. Retrieving a value from a char(20) field in a table returns a string that is padded to 20 characters (at least in SQL Server). Said colleague would retrieve CHAR data from a table, and then try to compare it to another string value (using == rather than .Equals()), and as we all know "TEXT" != "TEXT ", so he would trim everything to make sure that any equality test would work properly.

    However, that absolutely doesn't excuse calling .Trim() everywhere, and I never understood why he didn't write his stored procedures with RTRIM(field) so that the queries themselves would just return trimmed data and he wouldn't need to litter his code with .Trim().

  • Mike Dimmick (unregistered) in reply to Herr Otto Flick
    Comment held for moderation.
  • Anonymous.Trim() (unregistered)

    string.Empty.ToString.Trim()

    Better safe than sorry

  • JustHere (unregistered)

    if "True".ToString().Trim() == WTF.ToString().Trim() { return "Coder is a WTF"".ToString().Trim() }

  • NULL (unregistered)
    Comment held for moderation.
  • blah (unregistered)

    You may want to change the old gist to a popup alert, so people know to change their tm/gm script to the new url

  • Ulysses (unregistered)

    It's a perfectly suitable use of the Builder Pattern. :D

  • Randal L. Schwartz (google)

    Although "cargo cult" encompasses a collection of practices that are (falsely) applied to a discipline... I prefer to call this the "shaking a voodoo stick at" pattern. Maybe it helped at one point, perhaps for unrelated reasons, but now it seems to be needed everywhere, and for no reason.

  • Anon (unregistered)

    Even string constants may have any number of null characters at the end. So how do you expect to properly compare them? By trimming them, you know there will be exactly one null terminator on each side of the comparison. Problem solved.

  • dkf (nodebb) in reply to ray10k

    PHP?

    No. Since you're obviously ignorant, I'll give a straight answer (for once 😉). Tcl treats everything as strings, or rather they're formally the supertype of all other value types. (That says nothing about how they're implemented, of course.)

  • GAZZA (unregistered)

    The boolean and trim stuff is bozo, sure. But the rest is fine; the "date" that is being compared here is not a date field, but a date from a text box. That is already a string; Tyisha's coworker didn't convert the date to a string before checking to see whether or not it is valid. Presumably this is C# code, so I'd personally have used DateTime.TryParse here, but it's not necessarily wrong to have a library method to check if a string conforms to a valid date format (you might, for example, want some sort of logging to occur every time you make such a check, so it's convenient to abstract that out).

  • Kolchack (unregistered)

    Well, all of the above don't give a clue about the story behind "Text.ToString()" and "Trim().ToString().Trim()" ...

  • Hannes (unregistered) in reply to Herr Otto Flick

    Yes, of course "False".Trim() is dumb, even dumber than "TextBox.Text.ToString()". I'm just saying that I've found myself calling TRIM on stuff that really didn't need to be trimmed, like trying to trim a DateTime... in my defense, our database is a mess. Columns don't have very descriptive names, they are called stuff like "F196" or "F100" or "G000", so it's almost natural to write "SELECT TRIM(G000) FROM ...", even though G000 always contains exactly 5 digits and is 5 chars long.

  • Zenith (unregistered) in reply to Tyisha

    And that's great so long as you're the only developer and are consistent about it. Where it falls apart is when you're on a team of idiots who don't know about VAHRCHAR, don't use RTRIM/LTRIM, do blind string == comparisons everywhere, don't even think about sanitizing INSERT/UPDATE fields, and choose random lengths for the same column in two tables while suppressing exceptions so it's not safe to just copy from one to the other without ending up in a half-aborted state because they didn't use transactions. That kind of developer isn't careful about NULL either so even OP may end up with NullReferenceExceptions from those Trim() calls. Forget anything even remotely technical like the weirdly-terminated strings that come back from some Win32 calls.

    What I've done was call a static function that internally looks like [ function SafeClear (object o){return((o??"").trim());} ] because I was tired of being hauled into code review sessions over the inline version and then ended up being yelled at for the extra stack frame that it would've generated (if it hadn't drastically reduced the kind of stupid errors throwing us into the debugger in the first place). Yeah, a hypothetical 101 frames is so much worse than 100 real frames and is definitely what's killing performance in a system that uses Entity to cache entire databases per user session...

  • PSAdmin (unregistered)

    As someone who has done this I can explain the thought pattern. You may have written a simple script or program at some point that had to consume a string that was provided by a third party. That third party may have had a habit in the past of occasionally sending whitespace in places you didn't expect because it was sending data exactly as it was keyed with absolutely zero validation. You get burned one day. A field that should've contained a country code was a tab, a date of birth had spaces and so on. As a junior/inexperienced coder you get defensive and start trimming things every time you receive a string, or add some strings. Also I think some languages iterate differently. So you have these arrays that always end with a null entry. So rather than improving your level of understanding, just trim everything and pray a whitespace never appears in your dataset again.

  • James (unregistered)

    And the Format string gets Trim() called on it twice. I am partly surprised that this coworker doesn't use string.Trim().Trim().Trim().Trim()... ad infinitum everywhere.

  • Nick Groenewegen (unregistered)

    Has anyone of you thought that the reason behind this, is that the guy just doesn't know what the fuck he is doing?

  • lossardos (unregistered) in reply to Nick Groenewegen

    Or he has a rare case of OCD.

  • JimTonic (unregistered)

    Another WTF is initializing a variable to some value just to assign another value to it just 2 lines below. A pet peeve of mine.

  • Pista (unregistered) in reply to Sheriff Fatman
    Comment held for moderation.
  • vmp (unregistered)

    while (true) inputString = inputString.trim();

  • Chaoticmass (unregistered)

    I seem to remember in VB that converting from a number to a string would add a space to the front of the string. Maybe they were used to that. Still no excuse.

  • Plg (unregistered) in reply to dkf

    REXX.

  • megha (unregistered)
    Comment held for moderation.
  • Jack Stephen (unregistered)
    Comment held for moderation.
  • Lucky Patcher Android (unregistered)
    Comment held for moderation.
  • SirG Media Meetup (unregistered)
    Comment held for moderation.
  • SirG Media Meetup (unregistered)
    Comment held for moderation.
  • steve johnson (unregistered)
    Comment held for moderation.
  • ricky (unregistered)

    Great post.Thanks for sharing.

  • micheal (unregistered)
    Comment held for moderation.
  • shaun (unregistered)
    Comment held for moderation.
  • Jude (unregistered)
    Comment held for moderation.

Leave a comment on “Trimming the Fat”

Log In or post as a guest

Replying to comment #:

« Return to Article