• (disco)

    He was older, wiser, and armed with “real world” experience, but he kept wondering: how would that company do without their resident Expert Intern?

    Based on that code snippet, badly

  • (disco)
    “Read the code, didn’t see anything odd.” 
    if (isCodeValid(promo_code) || !isCodeValid(promo_code))
{
	addPromoToCart();
	displayPromoError();
}
else
{
	addPromoToCart();
	displayPromoError();
}

    Someone needs a new pair of glasses...

  • (disco)

    Paging @Remy - the front page is missing its discussion link again. Also, the topic is still hidden.

  • (disco)

    This topic is now (listed && !unlisted). It will be (displayed && !invisible) in topic lists.

  • (disco) in reply to JBert
    JBert:
    Paging @Remy - the front page is missing its discussion link again

    In fact all the post summaries on the front page are missing the correct links... (summary bodies display:none to show just the footers):

    [image]
  • (disco)

    And, of course, being an intern, he was getting paid at less than half what the full time devs were getting and providing superior effort. /sigh

  • (disco) in reply to PJH

    Nice find, though that seems to be a different bug. Click the comments link for last Thursday and you'll see the comments and link are there, the front page just won't count correctly.

    Today's article doesn't even have a link to Discourse on its comment page.

  • (disco) in reply to machtyn
    machtyn:
    And, of course, being an intern, he was getting paid at less than half what the full time devs were getting and providing superior effort.

    Here, you need to be a trainee for that. An intern is generally fully unpaid, or rather "paid in experience" (of which you need at least a month to get a bachelor's).

  • (disco) in reply to Maciejasjmj
    Maciejasjmj:
    An intern is generally fully unpaid, or rather "paid in experience" (of which you need at least a month to get a bachelor's).

    They might be paid at the minimum wage level, while aspiring to earn as much as the contract cleaning staff…

  • (disco) in reply to Maciejasjmj

    My company seems to have redefined what an intern is. They are hiring interns for the summer who have just graduated.

  • (disco)

    I'm surprised they didn't offer him a position and beg him to stay.

  • (disco) in reply to dkf
    dkf:
    They might be paid at the minimum wage level

    It's funny because here, minimum wage doesn't apply to contracts other than a proper work contract, and pretty much no trainees and interns get one - it's disadvantageous both to the employer (since they need to pay the social security stuff that the university pays already) and the worker (since they can get more money if the employer doesn't need to pay the aforementioned SS).

    tharpa:
    My company seems to have redefined what an intern is. They are hiring interns for the summer who have just graduated.

    Why not?

  • (disco) 
     if (isCodeValid(promo_code) || !isCodeValid(promo_code))
 {
       addPromoToCart();
       displayPromoError();
 }
 else
 {
       addPromoToCart();
       displayPromoError();
 }
 else
 {
  /** Bad Structure is a deliberate WTF in order to enhance the experience of "unreachable code" */
      if (FILE_NOT_FOUND)
      {
            /** Can't attach something to something that can't be found */
            displayNoComment();
      }
      else
      {
            /** Shouldn't attach credence to something that isn't valid */ 
            displayNoComment();
      }
}
  • (disco)

    Now should D.H. have actually fixed the other obvious bugs he found along the way or perhaps just logged them to bog down the Bozo who created them? Clearly the bug he was assigned should be fixed.

    al la. Joel's Getting Things Done When You're Only a Grunt article (Strategy 4 Neutralize The Bozos)

  • (disco) in reply to PJH
    PJH:
    In fact all the post summaries on the front page are missing the correct links... (summary bodies display:none to show just the footers):

    Isn't this normal? It happens almost every day for me, although normally the Sidebar is empty as well. Then mysteriously it comes right later on. I thought it was deliberate. This isn't called The Daily WTF for nothing... Every time I view the site, I say "WTF?"

  • (disco)

    Well-written narrative filler did not distract from clear WTF. +1 Would read again.

  • (disco) 
    if(article.hasComments() || !article.hasComments())
{
   showNoComments();
}
else
{
   showNoComments();
}
  • (disco) in reply to sloosecannon

    Now we know who's really responsible for @PaulaBean… ;)

  • (disco) in reply to tharpa
    tharpa:
    My company seems to have redefined what an intern is. They are hiring interns for the summer who have just graduated.
    But are they getting paid?
  • (disco) in reply to Maciejasjmj
    Maciejasjmj:
    It's funny because here, minimum wage doesn't apply to contracts other than a proper work contract, and pretty much no trainees and interns get one - it's disadvantageous both to the employer (since they need to pay the social security stuff that the university pays already) and the worker (since they can get more money if the employer doesn't need to pay the aforementioned SS).

    They can get more money, but then they're responsible for paying the SS tax. And I almost guarantee that the additional amount that the workers get is not enough to cover that tax as well.

  • (disco) in reply to machtyn
    machtyn:
    And, of course, being an intern, he was getting paid at less than half what the full time devs were getting and providing superior effort. /sigh

    And never has a better introduction to the real world been seen. Even more so if he ever managed to negotiate his own pay raise, because no one's going to look out for you but yourself.

  • (disco) in reply to JBert
    JBert:
    tharpa:
    My company seems to have redefined what an intern is. They are hiring interns for the summer who have just graduated.
    But are they getting paid?
    I assume they are getting something. I don't know if it's just a pittance, like most interns get.

    Slick Willie forever redefined the connotations of interns. Until 5 or 10 years ago, I think they had stopped using the term for that reason.

  • (disco) in reply to anotherusername

    Or just because they know he won't stay...

  • (disco) 
    if( isCodeValid(promo_code) || !isCodeValid(promo_code) )

    Schrodinger's boolean?

  • (disco) in reply to foxyshadis

    But, but, most of my managers look out for me and give me pay raises. I've yet to threaten to quit or such to get raises, stock options and bonuses. Maybe I just work at a rare non-wtf company.

  • (disco)

    Why is this CodeSOD posted as feature article ?

  • (disco) in reply to Astorlights

    Because somebody submitted it for the front page instead of posting it themselves in the sidebar. The best front page articles are usually CodeSOD, if they're not over-enhanced.

  • (disco) in reply to HardwareGeek

    What about Tales From The Interview? Those are often funny.

  • (disco) in reply to HardwareGeek
    HardwareGeek:
    posting it themselves in the sidebar.

    That would be Best of the Sidebar (and we're not getting too much of them these days).

    aliceif:
    What about Tales From The Interview?Those are often funny.

    Also rather rare, though.

  • (disco) in reply to Maciejasjmj
    Maciejasjmj:
    That would be Best of the Sidebar

    I should have said, "... posting it themselves in the forum." That's really what I meant, as opposed to submitting for the front page.

  • (disco) in reply to Masaaki_Hosoi

    Now this highligting [image] is… :wtf:

  • (disco) in reply to CodeSlave

    As much as he doing the right thing to fix the software, he was just enabling the bad coders and not getting credit for the bugs he fixed. He should have entered a ticket and immediately closed it.

  • (disco)

    Read the code, didn’t see anything odd.

    Clearly didn't 'read' the code very well.

  • (disco) in reply to Shoreline
    Shoreline:
    Clearly didn't 'read' the code very well.

    Brain rot, and not thinking about failure paths. It's Södertälje Syndrome. (Like Stockholm Syndrome, but much more WTFy…)

  • (disco) in reply to dkf
    dkf:
    Brain rot, and not thinking about failure paths. It's Södertälje Syndrome. (Like Stockholm Syndrome, but much more WTFy…)

    On top of that, people shouldn't be 'reading' the code looking for potential issues at all. Get some code coverage/very basic unit tests, and unreachable blocks will become very obvious very quickly.

    Once the unreachable block disappears, it's easy to see the reason why the logic doesn't run is because it's not designed to.

    This is the perils of not using machines properly (or at all) to complete mechanical tasks.

  • (disco) in reply to Shoreline
    Shoreline:
    Get some code coverage/very basic unit tests, and unreachable blocks will become very obvious very quickly.

    I use an IDE that greys them out.

    That's because I'm writing code in 2015, not 1993.

  • (disco) in reply to blakeyrat
    blakeyrat:
    I use an IDE that greys them out.

    Even better, although my IDE doesn't take a year to load or hang my computer, and I can use it in different operating systems.

    I guess it all comes down to an agreement that the code block is truly WTF, if the technology for avoiding it has been around since 1993.

    Here's an interesting insight into the state of our education system: There was no training with unit tests or code coverage in my degree. I found out about these things long after, probably by reading posts in this community.

  • (disco) in reply to Shoreline
    Shoreline:
    although my IDE doesn't take a year to load

    Not using a crap computer helps endlessly with that, too.

  • (disco) in reply to FrostCat

    Out of curiosity, I just timed Visual Studio 2013 on my i7 and SSD. 3 seconds from double-click to usable code editor. (And it was after a reboot, so nothing cached. Except Windows' predictive cache maybe.)

Leave a comment on “Welcome to the Real World”

Log In or post as a guest

Replying to comment #:

Log Out

« Return to Article