I was really shooting for zero BASIC posts this week. I love the language, and it's sad how easy it is to do some pretty bizarre things. But, I just couldn't resist posting this code from Ben that just screams Simplify Me: 

If ((mintAccessLevelForm = NO_ACCESS) Or _
        ((mintOperationMode = OP_NEW) And (mintAccessLevelForm = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelIndividuals = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAddressAlias = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelContracts = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCostCenter = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCorrespondence = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAccountProfile = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelInstructions = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelFBOVendors = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelFBOChains = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCatering = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelGround = READ_ACCESS) And _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAccountProfileOSR = READ_ACCESS)) Or _
        ((mintOperationMode = OP_NEW) And (mintAccessLevelForm <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelIndividuals <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAddressAlias <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelContracts <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCostCenter <> FULL_ACCESS)Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCorrespondence <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAccountProfile <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelInstructions <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelFBOVendors <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelFBOChains <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelCatering <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelGround <> FULL_ACCESS) Or _
         (mintOperationMode = OP_NEW) And (mintAccessLevelAccountProfileOSR <> FULL_ACCESS))) Then
         
            DisplayNoAccessMessage
            Exit Function
End If

As if that wasn't bad enough, Ben mentions:

All the non-constant variables (the ones that aren't capitalized) are pulled from the same function that does nothing but return the number 8 in a
complex way.  I broke it down and here's what this if-then statement really says:

IF 8 = 1 OR ( 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND
8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 =
2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2 AND 2 = 1 AND 8 = 2)
OR  (2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR
2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 =
1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1 AND 8 <> 8 OR 2 = 1
AND 8 <> 8) THEN

It's like they are checking to see if the rational laws of the universe apply.  At least that's the best I could make of it.  If 8 <> 8, then I'm throwing a HUGE exception!

[Advertisement] BuildMaster allows you to create a self-service release management platform that allows different teams to manage their applications. Explore how!