- Feature Articles
- CodeSOD
- Error'd
-
Forums
-
Other Articles
- Random Article
- Other Series
- Alex's Soapbox
- Announcements
- Best of…
- Best of Email
- Best of the Sidebar
- Bring Your Own Code
- Coded Smorgasbord
- Mandatory Fun Day
- Off Topic
- Representative Line
- News Roundup
- Editor's Soapbox
- Software on the Rocks
- Souvenir Potpourri
- Sponsor Post
- Tales from the Interview
- The Daily WTF: Live
- Virtudyne
Edit Admin
I was going to write something witty, but I ran out of budget.
Admin
there are at least InvalidCastException and KeyNotFoundException that can be thrown...
Admin
Sorry, software problems - there's nothing you can do about it... (Lame excuse that fits every budget!)
Edit Admin
"We'll fix it in the x.1 release."
Admin
This hits a bit too close to home. We had a HPC once, and management dismissed all my reservations regarding implementation because he was the HPC, after all. Then we run out of budget. And I had to fix all the bugs the HPC left in his wake. I'm no longer with that company.
Edit Admin
But it's overriding a function in the base class which could possibly change its behaviour depending on its own state.
Edit Admin
There is so much that bugs me here. Hardcoded dictionary key that looks like we're running logic over data that belongs in the presentation layer. A cast over extracting this field, repeated twice, which is not wrong per se but is a code smell, and is likely repeated elsewhere. Most puzzlingly of all, why is this method declared as
override
? Is there another implementation ofDoCompare
that this method overrides, and if yes, why are there two or more different implementations of the comparison of twoItem
objects?Edit Admin
Though "ran out of budget" is a silly way to put it, we've all(?) seen bugs that were closed as "not worth fixing." Whether there's more important features to implement, or more important fires to put out, there comes a point where you say "yes, that's a bug, but it doesn't have any impact worth mentioning, so it's not worth the dev-time to fix."
YMMV on exactly what "no impact worth mentioning" actually means.
Edit Admin
You made an unjustified assumption there. You see, this is .net, so languages like C# have indexers. It doesn't have to be a dictionary in the first place.