• (nodebb)

    I notice there's no mention of the discrepaency (or maybe discrepeancy) between the spelling of "discrepAncy" in the comment and "discrepEncy" in the name of the SP.

  • (nodebb)

    I've seen this before but with a twitst: using SSMS's query designer resulted in a mix of left and right joins making the relations almost impossible to follow. I've also had to fix a few, with a DB diagram in one hand and a very detailed description of what the query is supposed to return in the other. Usually is easier to rewrite the whole query from scratch than trying to fix the existing one.

  • (nodebb)

    DECLARE @tblReturn TABLE DECLARE @tblReturn1 TABLE DECLARE @tblReturn2 TABLE DECLARE @tblReturn3 TABLE

    My first problem is that I cannot search in the code exclusively for the first variable --- you'll hit all five. I hate that.

    Usually is easier to rewrite the whole query from scratch than trying to fix the existing one.

    Amen, brother.

  • (nodebb) in reply to dpm

    Use a modern text editor with "match whole word" option, duh. What are you in, like Linux console and Vim or whatever?

  • (nodebb)

    I once fixed an SP which was similar to this - took it from 10 minutes to 1 second execution time. And I've definitely seen a couple more like this (but didn't fix for whatever reason). This "approach" of querying the same tables 7 times with slightly different conditions is not that uncommon.

  • (nodebb) in reply to Mr. TA

    What are you in, like Linux console and Vim or whatever?

    Sounds like someone doesn't know how to use the tools correctly.

    /\<@tblReturn\>(((ENTER)))
  • (nodebb)

    If this was reviewed and passed, I imagine a whole lot of LGTM.

  • (nodebb)

    The core problem is that you guys are elitists who just understand SQL and all these table JOIN nonsense, and then keep snobbishly talking about "the big picture".

    And then there's the rest of us poor mundane programmers who understand it's all an ArrayList and a good ol' Java for loop to filter stuff. So we implement that process, which is nice and easy, but we're being forced to use that barbarian SQL language which doesn't even a good FOR loop instruction! Insane!

    /s

  • COBOL Dilettante (unregistered)

    This reminds me of a time when Teradata complained it was out of spool space in the face of the stupidly complex window function I'd given it, and I was able to "solve" this as:

    SELECT stupidly_complex_window

    FROM table

    WHERE id MOD 10 = 0

    UNION ALL

    SELECT stupidly_complex_window

    FROM table

    WHERE id MOD 10 = 1

    UNION ALL

    etc ...

    I was simultaneously relieved and disappointed when I worked out I could get what I wanted with a fraction of the effort by using something other than a stupidly complex window function

  • richarson (unregistered) in reply to mynameishidden

    Maybe they meant Looks Garbage To Me?

  • Someone (unregistered)

    I can't help but notice a discrepancy between the way some of those order states are named between each queries. Sounds like a lot of fun at the data level too.

  • (nodebb) in reply to Mr. TA

    took it from 10 minutes to 1 second execution time The problem is that management then think "Wow! Mr TA is a genius!", and not "Wow! The original programmer is super incompetent, and should not have been promoted twice already, or allowed to come within 100 yards of our codebase!".

    Addendum 2025-04-02 20:26: Oh, I need an extra line between the quote and my text.

  • LZ79LRU (unregistered)

    Nobody knows the queries I've seen. Nobody knows the horror...

  • NobodySpecific (unregistered)

    Well, at least one good thing can be said of this code: its whitespace was formatted nicely. Ideal line breaks, decent alignment of the left-padding, (tho I personally would use at most a 4-spaces tab width, I'm okay with the article's way).

    It is just too bad that the code within the whitespace is pure garbage.

  • xtal256 (unregistered)

    @NobodySpecific "tho I personally would use at most a 4-spaces tab width, I'm okay with the article's way"

    The article is using tabs, so it's your browser's fault for rendering them wider than 4 spaces. I wish Firefox (well, specifically Pale Moon) would let me configure this width.

  • Silent D (unregistered)

    TRWTF is the Hungarian notation used for the database column names. intOrderItemId, strStatus, and my favorite dtmTimeStamp.

Leave a comment on “Join Us in this Query”

Log In or post as a guest

Replying to comment #:

Log Out

« Return to Article