Forums
Tiberrias sends us some code that, on its face, without any context, doesn’t look bad.
var conditionId = _monitorConditionManagement.GetActiveConditionCountByClient(clientIdentityNumber);
_monitorConditionManagement.StopCondition(conditionId);
One of the key differences between a true WTF and an ugly hack is a degree of self-awareness. It's not a WTF if you know it's a WTF. If you've been doing this job for a non-zero amount of time, you have had a moment where you have a solution, and you know it's wrong, you know you shouldn't do this, but by the gods, it works and you've got more important stuff to worry about right now, so you just do it.
An anonymous submitter committed a sin, and has reached out to us for absolution.
When dealing with customers- and here, we mean, “off the street” customers- they often want to know “how long am I going to have to wait?” Whether we’re talking about a restaurant, a mechanic, a doctor’s office, or a computer/phone repair shop, knowing (and sharing with our customers) reasonable expectations about how much time they’re about to spend waiting.
Russell F works on an application which facilitates this sort of customer-facing management. It does much more, too, obviously, but one of its lesser features is to estimate how long a customer is about to spend waiting.
I think it’s fair to say that C, as a language, has never had a particularly great story for working with text. Individual characters are okay, but strings are a nightmare. The need to support unicode has only made that story a little more fraught, especially as older code now suddenly needs to support extended characters. And by “older” I mean, “wchar was added in 1995, which is practically yesterday in C time”.
Lexie inherited some older code. It was not designed to support unicode, which is certainly a problem in 2019, and it’s the problem Lexie was tasked with fixing. But it had an… interesting approach to deciding if a character was alphanumeric.
Tiffany started the code review with an apology. "I only did this to stay in style with the existing code, because it's either that or we rewrite the whole thing from scratch."
Jim J, who was running the code review nodded. Before Tiffany, this application had been designed from the ground up by Armando. Armando had gone to a tech conference, and learned about F#, and how all those exciting functional features were available in C#, and returned jabbering about "immutable data" and "functors" and "metaprogramming" and decided that he was now a functional programmer, who just happened to work in C#.
Bob E inherited a site which helps amateur sports clubs plan their recurring workouts/practices during the season. To do this, given the start date of the season, and the number of weeks, it needs to figure out all of the days in that range.
function GenWorkoutDates()
{
global $SeasonStartDate, $WorkoutDate, $WeeksInSeason;
$TempDate = explode("/", $SeasonStartDate);
for ($i = 1; $i <= $WeeksInSeason; $i++)
{
for ($j = 1; $j <= 7; $j++)
{
$MonthName = substr("JanFebMarAprMayJunJulAugSepOctNovDec", $TempDate[0] * 3 - 3, 3);
$WorkoutDate[$i][$j] = $MonthName . " " . $TempDate[1] . " ";
$TempDate[1] += 1;
switch ( $TempDate[0] )
{
case 9:
case 4:
case 6:
case 11:
$DaysInMonth = 30;
break;
case 2:
$DaysInMonth = 28;
switch ( $TempDate[2] )
{
case 2012:
case 2016:
case 2020:
$DaysInMonth = 29;
break;
default:
$DaysInMonth = 28;
break;
}
break;
default:
$DaysInMonth = 31;
break;
}
if ($TempDate[1] > $DaysInMonth)
{
$TempDate[1] = 1;
$TempDate[0] += 1;
if ($TempDate[0] > 12)
{
$TempDate[0] = 1;
$TempDate[2] += 1;
}
}
}
}
}Data type conversions are one of those areas where we have rich, well-supported, well-documented features built into most languages. Thus, we also have endless attempts for people to re-implement them. Or worse, wrap a built-in method in a way which makes everything less clear.
Mindy encountered this.
A few years ago, Naomi did an internship with Initech. Before her first day, she was very clear on what her responsibilities would be: she'd be on a team modernizing an older product called "Gem" (no relation to Ruby libraries).
By the time her first day rolled around, however, Initech had new priorities. There were a collection of fires on some hyperspecific internal enterprise tool, and everyone was running around and screaming about the apocalypse while dealing with that. Except Naomi, because nobody had any time to bring the intern up to speed on this disaster. Instead, she was given a new priority: just maintain Gem. And no, she wouldn't have a mentor. For the next six months, Naomi was the Gem support team.