• Jaloopa (unregistered)

    you have already done your frist release today

  • Darren (unregistered)

    I don't hate this. This is basically doing a retention policy on the number of backups they're keeping (except for when they're creating manual backups). It's probably not the most elegant way, but the code is pretty clear and easy to follow.

    If they were to put a build number as part of the filename then they'd have to find another way of managing them to avoid keeping a backup of every single build.

  • Hanzito (unregistered)

    The person that introduces a space in the backup directory path is in for a nice surprise.

  • (nodebb)

    Now, admittedly, I don't think a lot of folks want to do more than 9 releases in a given day, but there's no reason why they couldn't just keep trying until they find a good filename. Or even better, require each release to have an identifier (like the commit or build number or whatever) and then use that for the filenames.

    Or just add h:m:s to the timestamp in the file name.

  • (author) in reply to Darren

    As is, they're keeping 9 backups (potentially) for every day. So it doesn't really represent a meaningful retention policy, it just limits you to 3285 backups a year. Which sure, that should be enough for anybody, but honestly, if you're just having a script that deletes the backups from old days, your fine.

    Actually, as I think about this more, if you're doing a release that crosses a day boundary (you hit deploy at 2359, for example), I suspect this will blow up in interesting ways if a rollback happens.

  • Jason Stringify (unregistered)

    I always think that an exclamation mark on an error message is equivalent to adding "you idiot!" - as in "invalid entry!" - so having three here is like getting a punch in the face on top.

  • (nodebb)

    Someone was missing VAX/VMS.

  • Industrial Automation Engineer (unregistered)

    I wanted to comment, but I had to do it manually.

  • Darren (unregistered) in reply to Remy Porter

    Ah, yeah. Forgot that they were using the date as part of the backup filename. In which case, I do now kind of hate it...

  • (nodebb) in reply to Remy Porter

    Actually, as I think about this more, if you're doing a release that crosses a day boundary (you hit deploy at 2359, for example), I suspect this will blow up in interesting ways if a rollback happens.

    Not as interesting as they would be if the value of date was recalculated in every test...

  • Loren Pechtel (unregistered)
    Comment held for moderation.

Leave a comment on “Back Up for a Moment”

Log In or post as a guest

Replying to comment #:

Log Out

« Return to Article