• (nodebb)

    I was going to write something witty, but I ran out of budget.

  • L (unregistered)

    there are at least InvalidCastException and KeyNotFoundException that can be thrown...

  • Officer Johnny Holzkopf (unregistered) in reply to Mr. TA

    Sorry, software problems - there's nothing you can do about it... (Lame excuse that fits every budget!)

  • (nodebb)

    "We'll fix it in the x.1 release."

  • Pag (unregistered)

    The method can't be static because it's an override. The idea might be for different child classes to compare an Item using different criteria. They might have implemented the interface ICompare, but perhaps they chose not to.

  • ricecake (unregistered)

    It may be intended, but it also reverses the order of the comparison.

  • (nodebb)

    I'm actually more annoyed that the guy didn't implement IComparable<T> correctly. That pretty much already is an indication that the code will be complete sh*t.

  • Richard Brantley (unregistered)

    Now I'm imagining "System.BudgetExhaustedException".

  • Industrial Automation Engineer (unregistered)

    This hits a bit too close to home. We had a HPC once, and management dismissed all my reservations regarding implementation because he was the HPC, after all. Then we run out of budget. And I had to fix all the bugs the HPC left in his wake. I'm no longer with that company.

  • (nodebb)

    Also, DoCompare clearly should be static, but this is just pedantry.

    But it's overriding a function in the base class which could possibly change its behaviour depending on its own state.

  • Torgo (unregistered)

    At least they're sorry.

  • (nodebb)

    There is so much that bugs me here. Hardcoded dictionary key that looks like we're running logic over data that belongs in the presentation layer. A cast over extracting this field, repeated twice, which is not wrong per se but is a code smell, and is likely repeated elsewhere. Most puzzlingly of all, why is this method declared as override? Is there another implementation of DoCompare that this method overrides, and if yes, why are there two or more different implementations of the comparison of two Item objects?

  • (nodebb)

    Though "ran out of budget" is a silly way to put it, we've all(?) seen bugs that were closed as "not worth fixing." Whether there's more important features to implement, or more important fires to put out, there comes a point where you say "yes, that's a bug, but it doesn't have any impact worth mentioning, so it's not worth the dev-time to fix."

    YMMV on exactly what "no impact worth mentioning" actually means.

  • (nodebb) in reply to Maia-Everett

    You made an unjustified assumption there. You see, this is .net, so languages like C# have indexers. It doesn't have to be a dictionary in the first place.

  • enkorvaks (unregistered)

    Am I the only one annoyed that the actual comparison is thatDate.CompareTo(thisDate)? So a result of -1 means thatDate (which is item2, the second parameter) sorts before thisDate (item1). This seems backwards based on the parameter order.

  • (nodebb)

    Another WTF is that it reverses the usual comparison order. So basically if item1.CreateDate is greater than item2.CreateDate, this method will report that item2 is "greater" than item1.

  • Quirkafleeg (unregistered)

    I stopped taking pride in my work - and now I'm unemployable because no one wants to work with a work-shy developer... ...all because the budget ran out.

  • Marko (unregistered)

    This is custom code written to work against a Sitecore CMS instance. Item is a OOTB Sitecore class which encapsulates a set of values stored in fields in the database. Fields can be of different types (OOTB fields include DateField, DateTimeField, MultilistField, TextField, LinkField etc) with different accessor methods when cast to that field type.

    I haven't seen it before, but it wouldn't surprise me if the DoCompare code was in one of the Sitecore classes which is then being overridden by this code.

Leave a comment on “It's Not Wrong to Say We're Equal”

Log In or post as a guest

Replying to comment #:

Log Out

« Return to Article