• some guy (unregistered)

    Frist of all, the fix better include some unit tests.

  • some guy (unregistered)

    Frist of all, the fix better include some unit tests.

  • RLB (unregistered) in reply to some guy

    Frist of all, the fix better include some unit tests.

    To prevent reduplication, I presume?

  • Vera (unregistered)

    Might be a good idea to check the other code this guy added to the codebase, if this is the standard of quality he delivers.

  • Tim R (unregistered)

    why explicitly loop? what's wrong with something like [... new Set(zones)] ? (disclaimer I haven't tried it but surely it's something like that)

  • (nodebb)

    And who says unions aren't good for workers?

  • (nodebb)

    The icing on the cake is that the result of the union is assigned to accumulator, which, of course, does absolutely nothing because assignments to function arguments are lost after returning from the function. The reason reduce returns anything at all is because assignment is an expression that returns the assigned value, so _.union(currentValue) is returned from the lambda and becomes the new reduction result.

  • airdrik (unregistered)

    I was going to join the union, but since there was someone after me, I decided not to bother.

  • (nodebb)

    Ah, I see another person has to contend without useful unit tests.

Leave a comment on “Reduced to a Union”

Log In or post as a guest

Replying to comment #684435:

Log Out

« Return to Article